[Libreoffice-bugs] [Bug 39593] copy/paste code detector / fixing

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

Tor Lillqvist <***@iki.fi> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|***@gmail.com |libreoffice-***@lists.free
| |desktop.org

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #20 from Tor Lillqvist <***@iki.fi> ---
See bug #89267 for a specific, easy, already found case of copy-paste orgy.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

Michael Stahl <***@redhat.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Keywords| |topicCleanup

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

jan iversen <***@documentfoundation.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Whiteboard|target:4.1.0 target:4.2.0 |ToBeReviewed

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

jan iversen <***@documentfoundation.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Whiteboard|ToBeReviewed |

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

Commit Notification <libreoffice-***@lists.freedesktop.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Whiteboard| |target:5.4.0

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #23 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
qarkai committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b12823aa81003e80372bd89db79bd6ba8e032a95

tdf#39593 move duplicate code to separate method

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #24 from Mayank <***@gmail.com> ---
Is the bug settled ?

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #25 from Michael Meeks <***@collabora.com> ---
I suspect there is a lot more to do =) It would be good to have more up-to-date
output of Simian / CCFinderX or whatever to locate duplicate code ... Thanks.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #26 from Buovjaga <***@suomi24.fi> ---
Noel pointed out this tool:
https://pmd.github.io/pmd-5.5.5/usage/cpd-usage.html

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #27 from Ekansh Jha <***@gmail.com> ---
I am new to LO. Just want to ask if this issue is still open.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

Commit Notification <libreoffice-***@lists.freedesktop.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Whiteboard|target:5.4.0 |target:5.4.0 target:6.0.0

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #28 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
tagezi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a0ebba3d8855fee0bcec04a10137ae3a4f9f0e77

tdf#39593 deduplicate code in ExplicitValueProvider

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #29 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
tagezi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2f34bec2a7b939e24c3c5e884fdfe2057b732248

tdf#39593 deduplicate code in ScOutputData

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #30 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=95da9d4c8f320d865939ef2cea268ad1aac20a8e

Follow our naming conventions, tdf#39593 follow-up

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #31 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
tagezi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ca2bc4b6d8fb10b2b9d7bf9646b1be22be88e2ef

tdf#39593 deduplicate code in ScOutputData

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #32 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=45d6b9aa1986c5e68e7bf03d995bc1f8cd1bc817

Address some nitpicks, tdf#39593 follow-up

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

Commit Notification <libreoffice-***@lists.freedesktop.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Whiteboard|target:5.4.0 target:6.0.0 |target:5.4.0 target:6.0.0
| |target:6.1.0

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #33 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
tagezi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=eafc42a2b46e70a0840a870b8c8cce85b32980c1

tdf#39593 deduplicate code in ScOutputData

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #34 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
tagezi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5fe3117e1877fa0bfb55f1cf22cf9394b3f0795

tdf#39593 deduplicate code in ScCellShell

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #35 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
tagezi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e76bdaeb300e8420a8bc96e5e38b858821d22564

tdf#39593 deduplicate code in ScCellShell

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #36 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
tagezi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=22dc2e5cd3e06e12f08dbb86df2df86860d301d6

tdf#39593 deduplicate code in ScCellShell

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #37 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
Hrishabh committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f17a04df424dac553195c1922a4e4aa1f4ad5b9d

tdf#39593 fixed copy paste code in sw edlingu.cxx

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #38 from Sanket Kumar Singh <***@gmail.com> ---
I wish to work on this bug.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

Sanket Kumar Singh <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|libreoffice-***@lists.free |***@gmail.com
|desktop.org |
Status|NEW |ASSIGNED

--- Comment #39 from Sanket Kumar Singh <***@gmail.com> ---
I will start to work on this bug.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

Sanket Kumar Singh <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|***@gmail.com |libreoffice-***@lists.free
| |desktop.org

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

Xisco Faulí <***@libreoffice.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEW
CC| |***@libreoffice.org

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

Commit Notification <libreoffice-***@lists.freedesktop.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Whiteboard|target:5.4.0 target:6.0.0 |target:5.4.0 target:6.0.0
|target:6.1.0 |target:6.1.0 target:6.2.0

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #41 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
Arkadiy Illarionov committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=eada4adee8a32be021ee3031d07e0ccda7217e0d

tdf#39593 deduplicate code using existing function

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #42 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
tagezi committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/ddcd36d9d6191bfba7dea179067767a9ee192608%5E%21

tdf#39593 deduplicate code in TreeListBox

It will be available in 6.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

Commit Notification <libreoffice-***@lists.freedesktop.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Whiteboard|target:5.4.0 target:6.0.0 |target:5.4.0 target:6.0.0
|target:6.1.0 target:6.2.0 |target:6.1.0 target:6.2.0
| |target:6.3.0

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #43 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
Dmitriy Shilin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/6fa4c3e4778959d4591c053461329d396741ee64%5E%21

tdf#39593 vcl: extract SysColor list deletion

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #44 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
Dmitriy Shilin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/af4fab260b4e5e6cd073d449081dd057b9715881%5E%21

tdf#39593 vcl: reduce copy-paste in ImplCalcOutSideRgn

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

rajprakash <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED

--- Comment #45 from rajprakash <***@gmail.com> ---
Hi,

I just started working on it

Regards,
rajprakash

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #47 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
Dmitriy Shilin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/7311a88baa8c30eeb61d897f43ac3f5b481ed01f%5E%21

tdf#39593 vcl/win/gdi: extract brush updating into method

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

Xisco Faulí <***@libreoffice.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEW

--- Comment #48 from Xisco Faulí <***@libreoffice.org> ---
I guess many people can work on this at the same time...

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #46 from Commit Notification <libreoffice-***@lists.freedesktop.org> ---
Dmitriy Shilin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/53a29871800c5b520767e18c1e3f10c4d5c4852e%5E%21

tdf#39593 vcl/win/gdi: extract pen resetting into method

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.