[Libreoffice-bugs] [Bug 116529] New: (Notebookbar) Margins only show in CM

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=116529

Bug ID: 116529
Summary: (Notebookbar) Margins only show in CM
Product: LibreOffice
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Writer
Assignee: libreoffice-***@lists.freedesktop.org
Reporter: ***@hughes.net

Description:
On the tabbed Notebookbar in Writer, clicking the 'Page Margins' icon in the
'Page Layout' tab reveals a dropdown with the margin in centimeters despite
using inches as the default format.

Steps to Reproduce:
(See description)

Actual Results:
(See description)

Expected Results:
Margins should show in the user-defined unit of measurement.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101
Firefox/60.0

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=116529

Jacques Guilleron <***@aol.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
CC| |***@aol.com
Ever confirmed|0 |1

--- Comment #1 from Jacques Guilleron <***@aol.com> ---
Hi Joe,

I reproduce with
LO 6.1.0.0.alpha0+ Build ID: dd4f1b1bd31daf080dc0420524712dc244e539b5
CPU threads: 2; OS: Windows 6.1; UI render: default;
TinderBox: Win-***@42, Branch:master, Time: 2018-03-20_23:26:38
Locale: en-US (fr_FR); Calc: CL
and
LO 5.3.1.1 Build ID: 72fee18f394a980128dc111963f2eefb05998eeb
CPU Threads: 2; OS Version: Windows 6.1; UI Render: default; Layout Engine:
new;
Locale: en-US (fr_FR); Calc: CL

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=116529

Xisco Faulí <***@libreoffice.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@libreoffice.org
Blocks| |107237


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107237
[Bug 107237] [META] Notebookbar Tabbed Implementation

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=116529

Xisco Faulí <***@libreoffice.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Version|unspecified |6.0.0.0.alpha0+

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=116529

andreas_k <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #2 from andreas_k <***@gmail.com> ---
In 6.2 daily build I see default format. Can someone else verify if it will now
use the correct format.

Version: 6.2.0.0.beta1+ (x64)
Build ID: 46f2473fc88f922153247175dfac4c293eb356f8
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win;
TinderBox: Win-***@42, Branch:libreoffice-6-2, Time: 2018-12-07_23:20:05
Locale: de-AT (de_AT); UI-Language: en-US
Calc: threaded

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=116529

--- Comment #3 from Xisco Faulí <***@libreoffice.org> ---
Created attachment 147415
--> https://bugs.documentfoundation.org/attachment.cgi?id=147415&action=edit
still reproducible in LibreOffice 6.2 beta1

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=116529

Xisco Faulí <***@libreoffice.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@redhat.com

--- Comment #4 from Xisco Faulí <***@libreoffice.org> ---
I see 0cm is set in the .ui file ->
https://opengrok.libreoffice.org/xref/core/sw/uiconfig/swriter/ui/pagemargincontrol.ui#351
and looking for a similar commit where those values were deleted from the .ui
file, I found
https://cgit.freedesktop.org/libreoffice/core/commit/?id=4b7e2b8a64eca337ea06f7d11fc9d2f66a9d555e

@Caolán, Do you think the issue will get fixed if the widget is welded ?

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=116529

--- Comment #5 from Caolán McNamara <***@redhat.com> ---
Typically the thing that switches such MetricField/MetricSpinButton to inch vs
cm depending on the ui format is "SetFieldUnit", so I imagine someone needs to
try and and add a call of that on that widget