[Libreoffice-bugs] [Bug 121685] New: All images and text appear blurry/out of focus on Windows with fractions scaling

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

Bug ID: 121685
Summary: All images and text appear blurry/out of focus on
Windows with fractions scaling
Product: LibreOffice
Version: 6.3.0.0.alpha0+ Master
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: LibreOffice
Assignee: libreoffice-***@lists.freedesktop.org
Reporter: ***@hotmail.com

Created attachment 146988
--> https://bugs.documentfoundation.org/attachment.cgi?id=146988&action=edit
Comparison of About dialog box

In this range
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=0abce68927f45673b73d8f806e108a51a36fb543..e37b7e8a4730fad470b0b5daa0ab2bf905edc3a5

All UI and document content match the system scale factor. The problem is that
text is overly blurry. 'e' are especially hard to read. While the icon scale is
an improvement, the text should not be hard to read.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

Luke <***@hotmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
OS|All |Windows (All)

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

Oliver Brinzing <***@gmx.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
CC| |***@gmx.de
Ever confirmed|0 |1

--- Comment #1 from Oliver Brinzing <***@gmx.de> ---
confirming with win 10 (1920x1080, 125%), see attached screenshot
comparing lo 6.1.3.2 and lo 6.3

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

--- Comment #2 from Oliver Brinzing <***@gmx.de> ---
Created attachment 146998
--> https://bugs.documentfoundation.org/attachment.cgi?id=146998&action=edit
comparing lo 6.3 and lo 6.1.3.2 win 10 1920x1080, 125%

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

Luke <***@hotmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|UI and document content |UI and document content
|appear blurry/out of focus |appear blurry/out of focus
|on Windows with fractions |on Windows with fractional
|scaling after upgrade |scaling after upgrade

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

Luke <***@hotmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|All images and text appear |UI and document content
|blurry/out of focus on |appear blurry/out of focus
|Windows with fractions |on Windows with fractions
|scaling |scaling after upgrade

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

--- Comment #3 from Luke <***@hotmail.com> ---
Created attachment 147020
--> https://bugs.documentfoundation.org/attachment.cgi?id=147020&action=edit
Tinderbox vs Self-build

I had trouble bisecting this regression as the tinderbox and home builds
produce different results. Resetting my user profile resolved the issue.

I have 2 laptops both with HiDPI monitors. Both of them experienced this issue
when I upgraded to recent builds and Oliver had no issue reproducing this
either, so there is a real issue here. But it appears the cause is going to be
tricky to track down.

Steps to reproduce:
1. Settings->Display->Scale=125%
2. Install libreoffice 6.1
3. Launch LO 6.1
4. Upgrade to a recent build of 6.3
5. Compare document text or UI of 6.3 to 6.1.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

Luke <***@hotmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Keywords| |bibisectRequest, regression

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

--- Comment #4 from Luke <***@hotmail.com> ---
Ignore my last comment and my regression range in the description.

I'm having trouble bisecting this regression. Not sure if I'm making mistakes,
bug is profile dependent, or something else. I am sure the problem began around
11/21.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

--- Comment #7 from Miklos Vajna <***@collabora.com> ---
I would be surprised if those refactors would cause any functional change.
Maybe re-bisect with running soffice in safe mode to make sure your bisect
result is correct?

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

Roman Kuznetsov <***@mail.ru> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@mail.ru

--- Comment #5 from Roman Kuznetsov <***@mail.ru> ---
I bisected it, but not sure that I found right commit

8397f9937678e0e349dd08efa7dafe32cb4dfb08 is the first bad commit
commit 8397f9937678e0e349dd08efa7dafe32cb4dfb08
Author: Norbert Thiebaud <***@gmail.com>
Date: Thu Nov 29 11:41:15 2018 -0800

source sha:40710c488de3e4eef585c5a5276c9a0943d36f2e

source sha:40710c488de3e4eef585c5a5276c9a0943d36f2e

https://gerrit.libreoffice.org/#/q/40710c488de3e4eef585c5a5276c9a0943d36f2e

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

Roman Kuznetsov <***@mail.ru> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@collabora.com

--- Comment #6 from Roman Kuznetsov <***@mail.ru> ---
Miklos, can this commit make wrong rendering of GUI in LO?

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

Luke <***@hotmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@hotmail.com
See Also| |https://bugs.documentfounda
| |tion.org/show_bug.cgi?id=11
| |2536

--- Comment #8 from Luke <***@hotmail.com> ---
So by doing a 'make clean' between each bisect, I was able to track this
regression down to the exact cause

https://cgit.freedesktop.org/libreoffice/core/commit/?id=506173a7f42f34821238a63f3f8c7362c9fae9d9

tdf#112536 related: make soffice.bin a proper console application on Win

Mike,
Could you please take a look at this?

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

Luke <***@hotmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Keywords|bibisectRequest |bisected

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

--- Comment #9 from Mike Kaganski <***@hotmail.com> ---
(In reply to Luke from comment #8)

Thanks, Luke!

Yes, your bisection is right. The problem is that
solenv/gbuild/platform/com_MSC_class.mk only applies
solenv/gbuild/platform/DeclareDPIAware.manifest to applications with TARGETGUI.
Will fix that soon.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121685

Mike Kaganski <***@hotmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|libreoffice-***@lists.free |***@hotmail.com
|desktop.org |
Status|NEW |ASSIGNED

--- Comment #10 from Mike Kaganski <***@hotmail.com> ---
https://gerrit.libreoffice.org/64915

Luke: could you please test if it fixes the problem for you?