[Libreoffice-bugs] [Bug 121130] New: For icon-theme Colibre, the markers.png generated from markers.svg is not good enough

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121130

Bug ID: 121130
Summary: For icon-theme Colibre, the markers.png generated from
markers.svg is not good enough
Product: LibreOffice
Version: 6.2.0.0.alpha1+ Master
Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: LibreOffice
Assignee: libreoffice-***@lists.freedesktop.org
Reporter: ***@t-online.de

Created attachment 146256
--> https://bugs.documentfoundation.org/attachment.cgi?id=146256&action=edit
file as generated by LO6.2

For testing zip the icon-theme colibre_svg from source and put it into your
LibreOffice installation and rename it properly. Start LibreOffice and choose
this icon theme. Close and restart LibreOffice.

Start Writer and write some dummy text with several paragraphs. Insert an image
and anchor it to paragraph. Click the image. Then grap the anchor and drag it
to a different paragraph. Notice, that this is not possible.

The reason for this problem is, that the png-file, which is generated from the
svg-file has wrong size. That results in the effect, that a part of the
png-file is used for the anchor, which has a transparent line as first row and
first column. And with transparent row and column, grapping the anchor does not
work.

To get the needed size and position you have to remove one pixel on the left,
two pixel on the top and add one (transparent) pixel at the bottom.

With the wrong position and size, the square resize-markers are wrong too.

I have not tested, whether Breeze or Tango have the same problem.

Additional problems:

The round parts are generated wrongly, they have a rectangular corner top-left,
where there should have a curve.

The part bottom-left, which gives the center-marker for a rotation, looks very
ugly.

The generated folder is cache/colibre_svg/100 although my display scaling is
125%.

Only the combined markers.png was generated although the zip-file of the theme
contains the single marker files too.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121130

andreas_k <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #1 from andreas_k <***@gmail.com> ---
This is how I did the export from svg2png

inkscape -f "$i" -e "${i%.*}.png"
optipng -o7 "${i%.*}.png"

I first run inkscape to export the svg file into png and than I optimize the
png file with optipng.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121130

--- Comment #2 from andreas_k <***@gmail.com> ---
About marker there is markers.svg and in addition each marker icon is available
via marker-xxx

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121130

Regina Henschel <***@t-online.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|For icon-theme Colibre, the |markers.png generated from
|markers.png generated from |markers.svg is 118x93
|markers.svg is not good |instead of 117x92 and
|enough |therefore markers don't fit

--- Comment #3 from Regina Henschel <***@t-online.de> ---
The single markers are not generated automatically, but the markers.png is
generated from markers.svg.

The additional pixel is on the left and on the top edge. Therefor the markers
are wrongly cut. For markers, which have only small size compared to icons,
this 1px is important.

The export from Inksape is much better than the conversion by LibreOffice.

I have removed "Colibre", because it is a general problem for svg -> png.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121130

--- Comment #4 from andreas_k <***@gmail.com> ---
ok what's the problem here?

it look like the svg -> png output from libO add 1px cause the svg and png file
in colibre_svg/svx/res and colibre/svx/res have the right size

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121130

--- Comment #5 from Regina Henschel <***@t-online.de> ---
Created attachment 147381
--> https://bugs.documentfoundation.org/attachment.cgi?id=147381&action=edit
Compare markers

The image contains screenshots of a marked object.
The left part uses markers.png from "colibre". The middle part uses the
markers.png, which was generated from "colibre_svg". The right part uses a
markers.png where I have removed the additional pixel top and left from the
generated markers.png.

Notice in the middle, that the markers are wrongly cut from markers.png. The
bounding markers are not symmetric and the glue point markers have a gray line
at top.

The middle screenshot shows compared to the left one in addition, that the
generated markers.png seem to have got some anti-aliasing, which makes the
markers blurry.

The problem is, that the generated markers are ugly.

[b***@bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121130

Post by b***@bugs.documentfoundation.org
The problem is, that the generated markers are ugly.

That's the general problem of ALL svg icon themes. The LibO svg renderer
doesn't render nicely, but somewhere in the future the libo svg renderer will
improve.